Skip to content

fix: Starlette test application.#854

Merged
pvital merged 1 commit intomainfrom
starlette_fix
Mar 23, 2026
Merged

fix: Starlette test application.#854
pvital merged 1 commit intomainfrom
starlette_fix

Conversation

@pvital
Copy link
Member

@pvital pvital commented Mar 23, 2026

Starlette-1.0.0 removed on_startup and on_shutdown parameters from Starlette and Router, being replaced by lifespan.

Signed-off-by: Paulo Vital paulo.vital@ibm.com

Starlette-1.0.0 removed `on_startup` and `on_shutdown` parameters from
`Starlette` and `Router`, being replaced by `lifespan`.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital pvital requested a review from a team as a code owner March 23, 2026 15:16
@sonarqubecloud
Copy link

Copy link
Contributor

@arjun-rajappa arjun-rajappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pvital pvital self-assigned this Mar 23, 2026
@pvital pvital added currency Keeping supported versions updated. ci/cd fix labels Mar 23, 2026
@pvital pvital merged commit 2d3c4c8 into main Mar 23, 2026
19 checks passed
@pvital pvital deleted the starlette_fix branch March 23, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd currency Keeping supported versions updated. fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants